Add remaining bucket properties to PBC#30
Conversation
|
Note: this obsoletes #23. |
All known bucket properties are now supported. See basho/riak_pb#30 basho/riak_kv#488 basho/riak_api#21
ghost
assigned
There was a problem hiding this comment.
Why two revisions? Is it to keep step with Riak versions?
There was a problem hiding this comment.
We didn't change this for 1.3, so yes. There is a 1.3 tag, I believe.
There was a problem hiding this comment.
Running the riak-erlang-client I get the following error
https://gist.github.com/russelldb/3fcbf5089cc473184e62
And the code in that gist 'fixes' it (is there another way, yours looks like it should work?)
There was a problem hiding this comment.
I think the catch is wrong, it should just be exit:badarg.
There was a problem hiding this comment.
Nope, i'm still wrong, i can just make it the _:_ catch.
There was a problem hiding this comment.
Once more, with reading comprehension, the correct match in this case is error:badarg.
|
Do you think a riak test using the riak-erlang-client is in order? I don't mind writing it. |
|
WFM now, +1. What about that riak test? Maybe a roundtrip from HTTP->PB->HTTP for example? |
|
I will hack it out on the train today, thanks @russelldb |
Add remaining bucket properties to PBC
2 participants
NOTE: This is a protocol change only, related libraries that link directly (Riak, Erlang/Python/Java clients) will break with this patch until changes have been propagated.
This adds the remaining known bucket properties to the PBC messages. An effort has been made to avoid reimplementing JSON; instead the messages strive to have a more compact form but the
riak_pb_codecmodule modulates formats as necessary for compatibility. Additionally, arbitrary properties are not supported (although one can set them over HTTP), only properties that are known and used in Riak sub-applications are included.